diff options
| author |  Kemeng Shi <shikemeng@huaweicloud.com>
| 2023-09-27 18:35:13 +0800 |
|---|---|---|
| committer |  Andrew Morton <akpm@linux-foundation.org>
| 2023-10-18 14:34:15 -0700 |
| commit | 27e0db3c21aaf1422980e64b77956e15b839306f (patch) | |
| tree | 22263afa0610540d1f7d5e023f27ab823a638766 /mm/page_alloc.c | |
| parent | mmap: add clarifying comment to vma_merge() code (diff) | |
| download | linux-27e0db3c21aaf1422980e64b77956e15b839306f.tar.gz linux-27e0db3c21aaf1422980e64b77956e15b839306f.tar.bz2 linux-27e0db3c21aaf1422980e64b77956e15b839306f.zip | |
mm/page_alloc: remove unnecessary check in break_down_buddy_pages
Patch series "Two minor cleanups to break_down_buddy_pages", v2.
Two minor cleanups to break_down_buddy_pages.
This patch (of 2):
1. We always have target in range started with next_page and full free
range started with current_buddy.
2. The last split range size is 1 << low and low should be >= 0, then
size >= 1. So page + size != page is always true (because size > 0).
As summary, current_page will not equal to target page.
Link: https://lkml.kernel.org/r/20230927103514.98281-1-shikemeng@huaweicloud.com
Link: https://lkml.kernel.org/r/20230927103514.98281-2-shikemeng@huaweicloud.com
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Oscar Salvador <osalvador@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'mm/page_alloc.c')
| -rw-r--r-- | mm/page_alloc.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 85741403948f..fdb68b7c8240 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6480,10 +6480,8 @@ static void break_down_buddy_pages(struct zone *zone, struct page *page, if (set_page_guard(zone, current_buddy, high, migratetype)) continue; - if (current_buddy != target) { - add_to_free_list(current_buddy, zone, high, migratetype); - set_buddy_order(current_buddy, high); - } + add_to_free_list(current_buddy, zone, high, migratetype); + set_buddy_order(current_buddy, high); } } |