aboutsummaryrefslogtreecommitdiff
path: root/mm/vmscan.c
diff options
context:
space:
mode:
authorGravatar James Houghton <jthoughton@google.com> 2024-03-07 01:02:50 +0000
committerGravatar Andrew Morton <akpm@linux-foundation.org> 2024-03-12 13:07:17 -0700
commitb14d1671ddd3463b931fcdc442e0a74f8ae71406 (patch)
tree229bec6b73628f8cf2b5fb2ca88f48a7979f93e9 /mm/vmscan.c
parentmm: fix list corruption in put_pages_list (diff)
downloadlinux-b14d1671ddd3463b931fcdc442e0a74f8ae71406.tar.gz
linux-b14d1671ddd3463b931fcdc442e0a74f8ae71406.tar.bz2
linux-b14d1671ddd3463b931fcdc442e0a74f8ae71406.zip
mm: add an explicit smp_wmb() to UFFDIO_CONTINUE
Users of UFFDIO_CONTINUE may reasonably assume that a write memory barrier is included as part of UFFDIO_CONTINUE. That is, a user may believe that all writes it has done to a page that it is now UFFDIO_CONTINUE'ing are guaranteed to be visible to anyone subsequently reading the page through the newly mapped virtual memory region. Today, such a user happens to be correct. mmget_not_zero(), for example, is called as part of UFFDIO_CONTINUE (and comes before any PTE updates), and it implicitly gives us a write barrier. To be resilient against future changes, include an explicit smp_wmb(). While we're at it, optimize the smp_wmb() that is already incidentally present for the HugeTLB case. Merely making a syscall does not generally imply the memory ordering constraints that we need (including on x86). Link: https://lkml.kernel.org/r/20240307010250.3847179-1-jthoughton@google.com Signed-off-by: James Houghton <jthoughton@google.com> Reviewed-by: Peter Xu <peterx@redhat.com> Cc: Axel Rasmussen <axelrasmussen@google.com> Cc: Muchun Song <songmuchun@bytedance.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'mm/vmscan.c')
0 files changed, 0 insertions, 0 deletions