diff options
| author |  Eric Dumazet <edumazet@google.com>
| 2023-08-31 13:52:09 +0000 |
|---|---|---|
| committer |  David S. Miller <davem@davemloft.net>
| 2023-09-01 07:27:33 +0100 |
| commit | 5e6300e7b3a4ab5b72a82079753868e91fbf9efc (patch) | |
| tree | c0376ce7b3667e6187785217db48aec2fd17d29a /net/ipv4/tcp_output.c | |
| parent | net: use sk_forward_alloc_get() in sk_get_meminfo() (diff) | |
| download | linux-5e6300e7b3a4ab5b72a82079753868e91fbf9efc.tar.gz linux-5e6300e7b3a4ab5b72a82079753868e91fbf9efc.tar.bz2 linux-5e6300e7b3a4ab5b72a82079753868e91fbf9efc.zip | |
net: annotate data-races around sk->sk_forward_alloc
Every time sk->sk_forward_alloc is read locklessly,
add a READ_ONCE().
Add sk_forward_alloc_add() helper to centralize updates,
to reduce number of WRITE_ONCE().
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_output.c')
| -rw-r--r-- | net/ipv4/tcp_output.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index e6b4fbd642f7..ccfc8bbf7455 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -3474,7 +3474,7 @@ void sk_forced_mem_schedule(struct sock *sk, int size) if (delta <= 0) return; amt = sk_mem_pages(delta); - sk->sk_forward_alloc += amt << PAGE_SHIFT; + sk_forward_alloc_add(sk, amt << PAGE_SHIFT); sk_memory_allocated_add(sk, amt); if (mem_cgroup_sockets_enabled && sk->sk_memcg) |