diff options
| author |  Kuniyuki Iwashima <kuniyu@amazon.com>
| 2022-07-20 09:50:13 -0700 |
|---|---|---|
| committer |  David S. Miller <davem@davemloft.net>
| 2022-07-22 12:06:17 +0100 |
| commit | 02ca527ac5581cf56749db9fd03d854e842253dd (patch) | |
| tree | 7583b6174f943f876cffb6051295f0e2bfc00481 /net/ipv4 | |
| parent | tcp: Fix data-races around sysctl_tcp_dsack. (diff) | |
| download | linux-02ca527ac5581cf56749db9fd03d854e842253dd.tar.gz linux-02ca527ac5581cf56749db9fd03d854e842253dd.tar.bz2 linux-02ca527ac5581cf56749db9fd03d854e842253dd.zip | |
tcp: Fix a data-race around sysctl_tcp_app_win.
While reading sysctl_tcp_app_win, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/tcp_input.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 6fdad9505396..8cf4fbd349ab 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -534,7 +534,7 @@ static void tcp_grow_window(struct sock *sk, const struct sk_buff *skb, */ static void tcp_init_buffer_space(struct sock *sk) { - int tcp_app_win = sock_net(sk)->ipv4.sysctl_tcp_app_win; + int tcp_app_win = READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_app_win); struct tcp_sock *tp = tcp_sk(sk); int maxwin; |