diff options
| author |  Paolo Abeni <pabeni@redhat.com>
| 2021-02-11 15:30:40 -0800 |
|---|---|---|
| committer |  David S. Miller <davem@davemloft.net>
| 2021-02-11 18:30:54 -0800 |
| commit | d8b59efa64060d17b7b61f97d891de2d9f2bd9f0 (patch) | |
| tree | bb3711dda70f4a308641ae71bae513a5482ed51d /net/mptcp/protocol.c | |
| parent | mptcp: fix spurious retransmissions (diff) | |
| download | linux-d8b59efa64060d17b7b61f97d891de2d9f2bd9f0.tar.gz linux-d8b59efa64060d17b7b61f97d891de2d9f2bd9f0.tar.bz2 linux-d8b59efa64060d17b7b61f97d891de2d9f2bd9f0.zip | |
mptcp: init mptcp request socket earlier
The mptcp subflow route_req() callback performs the subflow
req initialization after the route_req() check. If the latter
fails, mptcp-specific bits of the current request sockets
are left uninitialized.
The above causes bad things at req socket disposal time, when
the mptcp resources are cleared.
This change addresses the issue by splitting subflow_init_req()
into the actual initialization and the mptcp-specific checks.
The initialization is moved before any possibly failing check.
Reported-by: Christoph Paasch <cpaasch@apple.com>
Fixes: 7ea851d19b23 ("tcp: merge 'init_req' and 'route_req' functions")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/mptcp/protocol.c')
0 files changed, 0 insertions, 0 deletions