diff options
author | 2017-12-21 10:29:09 -0800 | |
---|---|---|
committer | 2017-12-26 17:25:22 -0500 | |
commit | 6a6b0b9914e73a8a54253dd5f6f5e5dd5e4a756c (patch) | |
tree | 4b234f7585bf2dc12c0a6656e97073f215c1e4d1 /net/rds | |
parent | tipc: fix memory leak of group member when peer node is lost (diff) | |
download | linux-6a6b0b9914e73a8a54253dd5f6f5e5dd5e4a756c.tar.gz linux-6a6b0b9914e73a8a54253dd5f6f5e5dd5e4a756c.tar.bz2 linux-6a6b0b9914e73a8a54253dd5f6f5e5dd5e4a756c.zip |
tcp: Avoid preprocessor directives in tracepoint macro args
Using a preprocessor directive to check for CONFIG_IPV6 in the middle of
a DECLARE_EVENT_CLASS macro's arg list causes sparse to report a series
of errors:
./include/trace/events/tcp.h:68:1: error: directive in argument list
./include/trace/events/tcp.h:75:1: error: directive in argument list
./include/trace/events/tcp.h:144:1: error: directive in argument list
./include/trace/events/tcp.h:151:1: error: directive in argument list
./include/trace/events/tcp.h:216:1: error: directive in argument list
./include/trace/events/tcp.h:223:1: error: directive in argument list
./include/trace/events/tcp.h:274:1: error: directive in argument list
./include/trace/events/tcp.h:281:1: error: directive in argument list
Once sparse finds an error, it stops printing warnings for the file it
is checking. This masks any sparse warnings that would normally be
reported for the core TCP code.
Instead, handle the preprocessor conditionals in a couple of auxiliary
macros. This also has the benefit of reducing duplicate code.
Cc: David Ahern <dsahern@gmail.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rds')
0 files changed, 0 insertions, 0 deletions