diff options
| author |  Chuck Lever <chuck.lever@oracle.com>
| 2023-12-18 17:05:40 -0500 |
|---|---|---|
| committer | Chuck Lever <chuck.lever@oracle.com>
| 2023-12-18 17:10:52 -0500 |
| commit | bd018b98ba84ca0c80abac1ef23ce726a809e58c (patch) | |
| tree | 61ff44513af839d189d36961db69543fbedcdfe7 /net/smc/smc_llc.c | |
| parent | NFSD: Revert 738401a9bd1ac34ccd5723d69640a4adbb1a4bc0 (diff) | |
| download | linux-bd018b98ba84ca0c80abac1ef23ce726a809e58c.tar.gz linux-bd018b98ba84ca0c80abac1ef23ce726a809e58c.tar.bz2 linux-bd018b98ba84ca0c80abac1ef23ce726a809e58c.zip | |
SUNRPC: Revert 5f7fc5d69f6e92ec0b38774c387f5cf7812c5806
Guillaume says:
> I believe commit 5f7fc5d69f6e ("SUNRPC: Resupply rq_pages from
> node-local memory") in Linux 6.5+ is incorrect. It passes
> unconditionally rq_pool->sp_id as the NUMA node.
>
> While the comment in the svc_pool declaration in sunrpc/svc.h says
> that sp_id is also the NUMA node id, it might not be the case if
> the svc is created using svc_create_pooled(). svc_created_pooled()
> can use the per-cpu pool mode therefore in this case sp_id would
> be the cpu id.
Fix this by reverting now. At a later point this minor optimization,
and the deceptive labeling of the sp_id field, can be revisited.
Reported-by: Guillaume Morin <guillaume@morinfr.org>
Closes: https://lore.kernel.org/linux-nfs/ZYC9rsno8qYggVt9@bender.morinfr.org/T/#u
Fixes: 5f7fc5d69f6e ("SUNRPC: Resupply rq_pages from node-local memory")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Diffstat (limited to 'net/smc/smc_llc.c')
0 files changed, 0 insertions, 0 deletions