diff options
| author |  Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
| 2021-03-02 15:25:25 -0600 |
|---|---|---|
| committer |  Mark Brown <broonie@kernel.org>
| 2021-03-10 13:10:13 +0000 |
| commit | e699b2c89f8302c600d3373ae0ab12689bbf0da5 (patch) | |
| tree | 34966937b7c8a2480c65a9b4fd043204bca26abb /sound/soc/codecs/rt5682.c | |
| parent | ASoC: rt5677: remove useless assignment (diff) | |
| download | linux-e699b2c89f8302c600d3373ae0ab12689bbf0da5.tar.gz linux-e699b2c89f8302c600d3373ae0ab12689bbf0da5.tar.bz2 linux-e699b2c89f8302c600d3373ae0ab12689bbf0da5.zip | |
ASoC: rt5682: clarify expression
cppcheck warning:
sound/soc/codecs/rt5682.c:2401:65: style: Boolean result is used in
bitwise operation. Clarify expression with
parentheses. [clarifyCondition]
(pll_code.m_bp ? 0 : pll_code.m_code) << RT5682_PLL_M_SFT |
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210302212527.55158-23-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/rt5682.c')
| -rw-r--r-- | sound/soc/codecs/rt5682.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c index b306ac4b9b2e..e4542200009d 100644 --- a/sound/soc/codecs/rt5682.c +++ b/sound/soc/codecs/rt5682.c @@ -2396,10 +2396,10 @@ static int rt5682_set_component_pll(struct snd_soc_component *component, pll_code.n_code, pll_code.k_code); snd_soc_component_write(component, RT5682_PLL_CTRL_1, - pll_code.n_code << RT5682_PLL_N_SFT | pll_code.k_code); + (pll_code.n_code << RT5682_PLL_N_SFT) | pll_code.k_code); snd_soc_component_write(component, RT5682_PLL_CTRL_2, - (pll_code.m_bp ? 0 : pll_code.m_code) << RT5682_PLL_M_SFT | - pll_code.m_bp << RT5682_PLL_M_BP_SFT | RT5682_PLL_RST); + ((pll_code.m_bp ? 0 : pll_code.m_code) << RT5682_PLL_M_SFT) | + (pll_code.m_bp << RT5682_PLL_M_BP_SFT | RT5682_PLL_RST)); } rt5682->pll_in[pll_id] = freq_in; |