aboutsummaryrefslogtreecommitdiff
path: root/sound/soc/intel/boards/sof_cs42l42.c
diff options
context:
space:
mode:
authorGravatar Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> 2021-05-11 16:36:59 -0500
committerGravatar Mark Brown <broonie@kernel.org> 2021-05-12 13:02:47 +0100
commitad839121dd4cece991b995a4bbe83fdeac45ccd0 (patch)
treea882262046326fef650a7200b0f743d64024749c /sound/soc/intel/boards/sof_cs42l42.c
parentASoC: cs42l52: Minor tidy up of error paths (diff)
downloadlinux-ad839121dd4cece991b995a4bbe83fdeac45ccd0.tar.gz
linux-ad839121dd4cece991b995a4bbe83fdeac45ccd0.tar.bz2
linux-ad839121dd4cece991b995a4bbe83fdeac45ccd0.zip
ASoC: SOF: Intel: hda: fix index used in inner loop
With more warnings than the default, Sparse throws the following warning: sound/soc/sof/intel/hda.c:1127:49: error: self-comparison always evaluates to true sound/soc/sof/intel/hda.c:1128:49: error: self-comparison always evaluates to true sound/soc/sof/intel/hda.c:1129:48: error: self-comparison always evaluates to true This looks like an obvious error, with a likely copy-pasted line leading to the use of the wrong index in an inner loop. One of the worst single-character bugs in a long time. This problem was not detected in our tests since in practice SoundWire platforms only have identical devices per link and the index mistake did not change the results. Fixes: 6f5d506d7ff1dq ('ASoC: SOF: Intel: SoundWire: refine ACPI match') Reviewed-by: Paul Olaru <paul.olaru@oss.nxp.com> Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com> Reviewed-by: Rander Wang <rander.wang@intel.com> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20210511213707.32958-2-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/intel/boards/sof_cs42l42.c')
0 files changed, 0 insertions, 0 deletions