diff options
| author |  Dan Carpenter <dan.carpenter@oracle.com>
| 2018-07-13 18:05:57 +0300 |
|---|---|---|
| committer |  Mark Brown <broonie@kernel.org>
| 2018-07-13 16:26:09 +0100 |
| commit | b8110a87b75f948d978c06e130cc68026645c4a1 (patch) | |
| tree | 76cd6392e97820875d9de8b9e95f315507ec3664 /sound/soc/qcom | |
| parent | ASoC: qdsp6: q6asm-dai: do not close port if its not opened (diff) | |
| download | linux-b8110a87b75f948d978c06e130cc68026645c4a1.tar.gz linux-b8110a87b75f948d978c06e130cc68026645c4a1.tar.bz2 linux-b8110a87b75f948d978c06e130cc68026645c4a1.zip | |
ASoC: qdsp6: q6afe-dai: fix a range check in of_q6afe_parse_dai_data()
The main thing is that the data->priv[] array has AFE_PORT_MAX elements
so the > condition should be >=. But we may as well check for negative
values as well just to be safe.
Fixes: 24c4cbcfac09 ("ASoC: qdsp6: q6afe: Add q6afe dai driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/qcom')
| -rw-r--r-- | sound/soc/qcom/qdsp6/q6afe-dai.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/qcom/qdsp6/q6afe-dai.c b/sound/soc/qcom/qdsp6/q6afe-dai.c index a373ca5523ff..9ba95956ada8 100644 --- a/sound/soc/qcom/qdsp6/q6afe-dai.c +++ b/sound/soc/qcom/qdsp6/q6afe-dai.c @@ -1183,7 +1183,7 @@ static void of_q6afe_parse_dai_data(struct device *dev, int id, i, num_lines; ret = of_property_read_u32(node, "reg", &id); - if (ret || id > AFE_PORT_MAX) { + if (ret || id < 0 || id >= AFE_PORT_MAX) { dev_err(dev, "valid dai id not found:%d\n", ret); continue; } |