diff options
| author |  Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
| 2024-04-26 10:30:33 -0500 |
|---|---|---|
| committer |  Mark Brown <broonie@kernel.org>
| 2024-04-29 23:48:56 +0900 |
| commit | e8a6a5ad73acbafd98e8fd3f0cbf6e379771bb76 (patch) | |
| tree | ff1d2903df8f3653c22045da9abceab66976f6ec /sound | |
| parent | ASoC: meson: cards: select SND_DYNAMIC_MINORS (diff) | |
| download | linux-e8a6a5ad73acbafd98e8fd3f0cbf6e379771bb76.tar.gz linux-e8a6a5ad73acbafd98e8fd3f0cbf6e379771bb76.tar.bz2 linux-e8a6a5ad73acbafd98e8fd3f0cbf6e379771bb76.zip | |
ASoC: da7219-aad: fix usage of device_get_named_child_node()
The documentation for device_get_named_child_node() mentions this
important point:
"
The caller is responsible for calling fwnode_handle_put() on the
returned fwnode pointer.
"
Add fwnode_handle_put() to avoid a leaked reference.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20240426153033.38500-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/soc/codecs/da7219-aad.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/sound/soc/codecs/da7219-aad.c b/sound/soc/codecs/da7219-aad.c index 6bc068cdcbe2..15e5e3eb592b 100644 --- a/sound/soc/codecs/da7219-aad.c +++ b/sound/soc/codecs/da7219-aad.c @@ -671,8 +671,10 @@ static struct da7219_aad_pdata *da7219_aad_fw_to_pdata(struct device *dev) return NULL; aad_pdata = devm_kzalloc(dev, sizeof(*aad_pdata), GFP_KERNEL); - if (!aad_pdata) + if (!aad_pdata) { + fwnode_handle_put(aad_np); return NULL; + } aad_pdata->irq = i2c->irq; @@ -753,6 +755,8 @@ static struct da7219_aad_pdata *da7219_aad_fw_to_pdata(struct device *dev) else aad_pdata->adc_1bit_rpt = DA7219_AAD_ADC_1BIT_RPT_1; + fwnode_handle_put(aad_np); + return aad_pdata; } |