diff options
| author |  Xu Kuohai <xukuohai@huawei.com>
| 2022-10-11 08:01:05 -0400 |
|---|---|---|
| committer |  Andrii Nakryiko <andrii@kernel.org>
| 2022-10-13 10:53:22 -0700 |
| commit | 6e8280b958c5d7edc514cf347a800b23b7732b2b (patch) | |
| tree | dd89061a3f008f63487277a0f3ed2710b2aae3ec /tools/testing/selftests/bpf/prog_tests/tracing_struct.c | |
| parent | libbpf: Fix memory leak in parse_usdt_arg() (diff) | |
| download | linux-6e8280b958c5d7edc514cf347a800b23b7732b2b.tar.gz linux-6e8280b958c5d7edc514cf347a800b23b7732b2b.tar.bz2 linux-6e8280b958c5d7edc514cf347a800b23b7732b2b.zip | |
selftests/bpf: Fix memory leak caused by not destroying skeleton
Some test cases does not destroy skeleton object correctly, causing ASAN
to report memory leak warning. Fix it.
Fixes: 0ef6740e9777 ("selftests/bpf: Add tests for kptr_ref refcounting")
Fixes: 1642a3945e22 ("selftests/bpf: Add struct argument tests with fentry/fexit programs.")
Signed-off-by: Xu Kuohai <xukuohai@huawei.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Martin KaFai Lau <martin.lau@kernel.org>
Link: https://lore.kernel.org/bpf/20221011120108.782373-4-xukuohai@huaweicloud.com
Diffstat (limited to 'tools/testing/selftests/bpf/prog_tests/tracing_struct.c')
| -rw-r--r-- | tools/testing/selftests/bpf/prog_tests/tracing_struct.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/testing/selftests/bpf/prog_tests/tracing_struct.c b/tools/testing/selftests/bpf/prog_tests/tracing_struct.c index d5022b91d1e4..48dc9472e160 100644 --- a/tools/testing/selftests/bpf/prog_tests/tracing_struct.c +++ b/tools/testing/selftests/bpf/prog_tests/tracing_struct.c @@ -15,7 +15,7 @@ static void test_fentry(void) err = tracing_struct__attach(skel); if (!ASSERT_OK(err, "tracing_struct__attach")) - return; + goto destroy_skel; ASSERT_OK(trigger_module_test_read(256), "trigger_read"); @@ -54,6 +54,7 @@ static void test_fentry(void) ASSERT_EQ(skel->bss->t5_ret, 1, "t5 ret"); tracing_struct__detach(skel); +destroy_skel: tracing_struct__destroy(skel); } |