diff options
author | 2020-07-28 00:32:41 -0700 | |
---|---|---|
committer | 2020-08-31 15:20:40 -0600 | |
commit | f69237e1e954b469175de4af8487c303d36c5467 (patch) | |
tree | fe8b28077b40f2601202e035f36e289bb6080052 /tools/testing/selftests/firmware | |
parent | selftests: use "$(MAKE)" instead of "make" for headers_install (diff) | |
download | linux-f69237e1e954b469175de4af8487c303d36c5467.tar.gz linux-f69237e1e954b469175de4af8487c303d36c5467.tar.bz2 linux-f69237e1e954b469175de4af8487c303d36c5467.zip |
selftests: more general make nesting support
selftests can be built from the toplevel kernel makefile (e.g. make
kselftest-all) or directly (make -C tools/testing/selftests all).
The toplevel kernel makefile explicitly disables implicit rules with
"MAKEFLAGS += -rR", which is passed to tools/testing/selftests. Some
selftest makefiles require implicit make rules, which is why
commit 67d8712dcc70 ("selftests: Fix build failures when invoked from
kselftest target") reenables implicit rules by clearing MAKEFLAGS if
MAKELEVEL=1.
So far so good. However, if the toplevel makefile is called from an
outer makefile then MAKELEVEL will be elevated, which breaks the
MAKELEVEL equality test.
Example wrapped makefile error:
$ cat ~/Makefile
all:
$(MAKE) defconfig
$(MAKE) kselftest-all
$ make -sf ~/Makefile
futex_wait_timeout.c /src/tools/testing/selftests/kselftest_harness.h /src/tools/testing/selftests/kselftest.h ../include/futextest.h ../include/atomic.h ../include/logging.h -lpthread -lrt -o /src/tools/testing/selftests/futex/functional/futex_wait_timeout
make[4]: futex_wait_timeout.c: Command not found
Rather than checking $(MAKELEVEL), check for $(LINK.c), which is a more
direct side effect of "make -R". This enables arbitrary makefile
nesting.
Signed-off-by: Greg Thelen <gthelen@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'tools/testing/selftests/firmware')
0 files changed, 0 insertions, 0 deletions