diff options
| author |  Colin Ian King <colin.i.king@intel.com>
| 2024-01-06 12:42:13 +0000 |
|---|---|---|
| committer |  Oded Gabbay <ogabbay@kernel.org>
| 2024-02-26 09:30:40 +0200 |
| commit | 5ae8b6b774732d38840dd7562dc14d1950530023 (patch) | |
| tree | 43430a8dc617beb413e9660c3deddf97667a1fc2 /drivers/accel | |
| parent | accel/habanalabs/gaudi2: fail memory memset when failing to copy QM packet to... (diff) | |
| download | linux-5ae8b6b774732d38840dd7562dc14d1950530023.tar.gz linux-5ae8b6b774732d38840dd7562dc14d1950530023.tar.bz2 linux-5ae8b6b774732d38840dd7562dc14d1950530023.zip | |
accel/habanalabs/goya: remove redundant assignment to pointer 'input'
The pointer input is assigned a value that is not read, it is
being re-assigned again later with the same value. Resolve this
by moving the declaration to input into the if block.
Cleans up clang scan build warning:
warning: Value stored to 'input' during its initialization is never
read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@intel.com>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Diffstat (limited to 'drivers/accel')
| -rw-r--r-- | drivers/accel/habanalabs/goya/goya_coresight.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/accel/habanalabs/goya/goya_coresight.c b/drivers/accel/habanalabs/goya/goya_coresight.c index 41cae5fd843b..3827ea4c02f7 100644 --- a/drivers/accel/habanalabs/goya/goya_coresight.c +++ b/drivers/accel/habanalabs/goya/goya_coresight.c @@ -576,7 +576,6 @@ static int goya_config_spmu(struct hl_device *hdev, struct hl_debug_params *params) { u64 base_reg; - struct hl_debug_params_spmu *input = params->input; u64 *output; u32 output_arr_len; u32 events_num; @@ -592,7 +591,7 @@ static int goya_config_spmu(struct hl_device *hdev, base_reg = debug_spmu_regs[params->reg_idx] - CFG_BASE; if (params->enable) { - input = params->input; + struct hl_debug_params_spmu *input = params->input; if (!input) return -EINVAL; |